Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add order to scan valid_parts #207

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add order to scan valid_parts #207

wants to merge 1 commit into from

Conversation

MSadeghzadehG
Copy link

@MSadeghzadehG MSadeghzadehG commented Apr 17, 2020 •
edited
Loading

I didn't see any other parts that need to change. if there is, please mention.

@MSadeghzadehG MSadeghzadehG mentioned this pull request Apr 17, 2020
Closed
@MSadeghzadehG
Copy link
Author

PTAL @john-bodley @mistercrunch

@JustFeng
Copy link

thx

@john-bodley
Copy link
Contributor

@MSadeghzadehG should the list contain all the scan-query properties?

@MSadeghzadehG
Copy link
Author

MSadeghzadehG commented Apr 21, 2020 •
edited
Loading

@john-bodley the resultFormat, batch_size, and legacy are missing. and I didn't see metrics property in scan query parameters.
and I think the batch_size should add to the list. what's your opinion?

@MSadeghzadehG
Copy link
Author

@JustFeng you're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MSadeghzadehG @JustFeng @john-bodley